Skip to content

chore: resolve lint error in utils/async/while #8269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 7, 2025
Merged

chore: resolve lint error in utils/async/while #8269

merged 17 commits into from
Nov 7, 2025
+2 −2

Conversation

@SuYaSh-PaThAk04
Copy link
Contributor

@SuYaSh-PaThAk04 SuYaSh-PaThAk04 commented Oct 23, 2025 •
edited by kgryte
Loading

Resolves a part of #8268 .

Description

What is the purpose of this pull request?

This pull request:

  • resolve a lint error in utils/async/while.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@SuYaSh-PaThAk04
Create beep.js
e7e8649 
Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Create beep.js
ea32fcb 
Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Delete tools/make/lib/lint/javascript/beep.js
38fa07e 
Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Merge branch 'stdlib-js:develop' into develop
1cb0826
@SuYaSh-PaThAk04
Update eslint.mk
23a2b4f 
Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Delete beep.js
2bd08ee 
Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Merge branch 'stdlib-js:develop' into develop
6d15877
@SuYaSh-PaThAk04
Merge branch 'stdlib-js:develop' into develop
0185527
@SuYaSh-PaThAk04
Add self-import to index.js for linting compliance
9f8fca9 
Added a self-import to satisfy linting rules.

Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Update main.js
0878f6b 
Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Fix argument handling in async while function
3ee6f99 
Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Oct 23, 2025
@SuYaSh-PaThAk04
Simplify linting logic in eslint.mk
662db12 
Signed-off-by: Suyash Pathak <[email protected]>
@SuYaSh-PaThAk04
Correct echo command in eslint.mk
c3839bf 
Fix echo command in eslint-files target for linting.

Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Oct 23, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
utils/async/while $\color{green}185/185$
$color{green}+100.00%$ 		$\color{green}22/22$
$color{green}+100.00%$ 		$\color{green}3/3$
$color{green}+100.00%$ 		$\color{green}185/185$
$color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Nov 7, 2025
kgryte
kgryte reviewed Nov 7, 2025
View reviewed changes
@kgryte kgryte changed the title feat: add async while loop utility (whileAsync) chore: resolve lint error in utils/async/while Nov 7, 2025
kgryte
kgryte approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Nov 7, 2025
@SuYaSh-PaThAk04
Copy link
Contributor Author

SuYaSh-PaThAk04 commented Nov 7, 2025

LGTM after clean-up.

Thank you sir are there any suggestions or changes ?

@kgryte
Copy link
Member

kgryte commented Nov 7, 2025

See my changes.

@kgryte kgryte merged commit b9b8bcf into stdlib-js:develop Nov 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuYaSh-PaThAk04 @stdlib-bot @kgryte